Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MB-63334: Fix race condition in NormalizeVector #2094

Merged
merged 1 commit into from
Nov 4, 2024
Merged

MB-63334: Fix race condition in NormalizeVector #2094

merged 1 commit into from
Nov 4, 2024

Conversation

CascadingRadium
Copy link
Member

  • Normalizing the query vector in place would create a race condition, causing different
    indexes within an alias to receive inconsistent query vectors.
  • This inconsistency could lead to incorrect results when merging hits from all indexes in the
    alias.

@abhinavdangeti abhinavdangeti added this to the v2.4.3 milestone Nov 4, 2024
@abhinavdangeti abhinavdangeti merged commit cb1810f into master Nov 4, 2024
9 checks passed
@abhinavdangeti abhinavdangeti deleted the cohere branch November 4, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdangeti abhinavdangeti abhinavdangeti approved these changes

@Thejas-bhat Thejas-bhat Awaiting requested review from Thejas-bhat

@metonymic-smokey metonymic-smokey Awaiting requested review from metonymic-smokey

@Likith101 Likith101 Awaiting requested review from Likith101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@CascadingRadium @abhinavdangeti