MB-62230: Added params in KNN request when parsing a query #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonymic-smokey
changed the title
metonymic-smokey
requested review from
abhinavdangeti,
Thejas-bhat,
CascadingRadium,
Likith101 and
moshaad7
abhinavdangeti
requested changes
Sep 13, 2024
| @@ -196,6 +197,7 @@ func (r *SearchRequest) UnmarshalJSON(input []byte) error { | |||
| r.KNN[i].VectorBase64 = temp.KNN[i].VectorBase64 | |||
| r.KNN[i].K = temp.KNN[i].K | |||
| r.KNN[i].Boost = temp.KNN[i].Boost | |||
| r.KNN[i].Params = temp.KNN[i].Params | |||
There was a problem hiding this comment.
Was this a regression from the previous change?
There was a problem hiding this comment.
yes, fixed in this commit.
metonymic-smokey
force-pushed
the
params
branch
from
f59776f
to
5a9c121
Compare
abhinavdangeti
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for search-time params in the query parser and custom JSON unmarshaling logic.