Introducing resource limits on Windows #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces resource limits on Windows. These are not request-specific limits, but cumulative limits for all Blockless Runtime executions.
Implementation
Resource limits are set using Job Objects.
Since Go syscall documentation is scarce, here is MSDN documentation for relevant syscalls:
Testing
To test this manually, I used this code to spin up a number of processes, and the hcsshim jobobject-util tool to query resource limits for the job object; also tweaked it locally to print out pids of the assigned processes.
Also tested with a full-fledged
executor
.For Go test code, I spun up another process doing a sleep* and created resource limits for it.
* - because Windows doesn't have
sleep
by default andtimeout.exe
cannot be used in scripts, I used a variant with a ping to localhost to simulate sleep