Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for API package #63

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Add tests for API package #63

merged 3 commits into from
Mar 29, 2023

Conversation

Maelkum
Copy link
Contributor

@Maelkum Maelkum commented Mar 29, 2023

@dmikey Inspired by your comment that there's a bug in how the API behaves on function install code path, I figured it was good to add tests to the API package as well, so we don't have any surprises.

This PR adds tests to the API package, with the test coverage for the package now at 97.7%.

Tests typically cover three scenarios:

  1. nominal case - everything works as expected
  2. error - one of the node methods tasked with doing something failed
  3. invalid payload - e.g. malformed JSON

@Maelkum Maelkum self-assigned this Mar 29, 2023
@Maelkum Maelkum requested a review from dmikey March 29, 2023 15:48
@dmikey dmikey merged commit 37208c7 into main Mar 29, 2023
@dmikey dmikey deleted the api-tests branch April 11, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants