Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split worker and head node implementations #178

Merged
merged 7 commits into from
Dec 27, 2024
Merged

Split worker and head node implementations #178

merged 7 commits into from
Dec 27, 2024

Conversation

Maelkum
Copy link
Contributor

@Maelkum Maelkum commented Dec 25, 2024

This PR splits the head and worker node to separate packages, with the shared functionality existing in a new node core implementation.

Node core <=> worker + head node

Add handling for a "WorkOrder" message

Update head node

Topic handling in main instead of in node

Start of setting up a common "run" method + minor changes

Add description

Moving out handlers - install and healtcheck

Further trim ported handlers

Removing ported config options

Remove more ported stuff

Offload more common things to the node core

Move most of message processing code to the node core

Move notifiee code out of "node" package

Update node initialization, make node core public/usable outside of worker and head node

Add methods for the node API to the new head node impl

Fix worker execution

Update pBFT execution

Worker node - work order tests

Add more test cases to work order

Update but move the integration tests

Move/add integration test for PBFT

Move more tests/remove obsolete code

Move (uncompleted) last piece of test from the old node codebase

Remove file - TBD later

Remove obsolete file

Head node - simplify roll call/work order request creation

Trim down roll call struct - remove "Origin" field
@Maelkum Maelkum self-assigned this Dec 25, 2024
@Maelkum Maelkum requested a review from dmikey December 25, 2024 09:35
@Maelkum Maelkum changed the title Split worker and head node implementation Split worker and head node implementations Dec 25, 2024
Copy link
Contributor

@dmikey dmikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love the changes to the clarity towards what the nodes are doing!

@dmikey dmikey merged commit 23ea523 into main Dec 27, 2024
5 checks passed
@dmikey dmikey deleted the node-split branch December 27, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants