Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type support in inferences and criticisms #561

Merged
merged 10 commits into from
Mar 19, 2017
Merged

Improve type support in inferences and criticisms #561

merged 10 commits into from
Mar 19, 2017

Conversation

dustinvtran
Copy link
Member

@dustinvtran dustinvtran commented Mar 19, 2017 •
edited
Loading

This

  • raises more informative errors for type mismatches;
  • streamlines the logic for type checking;
  • provides support for more types, such as list and str;
  • removes unnecessary type casting in examples.

Fixes #560. Related to #188.

todo

  • Do the same for ed.evaluate and ed.ppc.
  • Add more unit tests.

@dustinvtran dustinvtran changed the title [WIP] Improve type support in inferences and criticisms Improve type support in inferences and criticisms Mar 19, 2017
@dustinvtran dustinvtran force-pushed the fix/issue-560 branch 2 times, most recently from 38cb1b1 to e48aa80 Compare March 19, 2017 06:51
@dustinvtran dustinvtran merged commit 4395319 into master Mar 19, 2017
@dustinvtran dustinvtran deleted the fix/issue-560 branch March 19, 2017 07:18
@dustinvtran dustinvtran mentioned this pull request Mar 20, 2017
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dustinvtran