-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a few inference tests #487
Conversation
Thanks Alp. I'll look into KLpq and SGLD. related #174 |
75f878e
to
5ba1214
Compare
hi @akucukelbir | i fixed the sgld and klpq tests. for SGLD, i just lowered the tolerance because it looks like it's converging but needs more samples. for klpq, it's the bias issue @naesseth mentioned in #296; i upped the number of samples to be 25 and it looks like it's converging. Let me know if you approve of my changes. If so, please merge this PR, or comment otherwise. |
LGTM. I'm surprised the KLpq issue is due to bias on such a simple/small problem. Somehow I would've expected it to exhibit itself in larger models, but I guess I was mistaken. We need to edit the website, I'll make an issue after closing this PR. |
Summary:
Implements basic inference tests under
tests/test-inferences
Tests that fail (commented out):
Intended Effect:
Make sure we break fewer things in the future
How to Verify:
py.test tests/test-inferences
Side Effects:
N/A
Documentation:
N/A
Reviewer Suggestions:
@dustinvtran