Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a few inference tests #487

Merged
merged 21 commits into from
Feb 28, 2017
Merged

Implement a few inference tests #487

merged 21 commits into from
Feb 28, 2017

Conversation

akucukelbir
Copy link
Contributor

@akucukelbir akucukelbir commented Feb 28, 2017

Summary:

Implements basic inference tests under tests/test-inferences

Tests that fail (commented out):

  • KLpq
  • SGLD

Intended Effect:

Make sure we break fewer things in the future

How to Verify:

py.test tests/test-inferences

Side Effects:

N/A

Documentation:

N/A

Reviewer Suggestions:

@dustinvtran

@dustinvtran
Copy link
Member

dustinvtran commented Feb 28, 2017

Thanks Alp. I'll look into KLpq and SGLD.

related #174

@dustinvtran
Copy link
Member

dustinvtran commented Feb 28, 2017

hi @akucukelbir | i fixed the sgld and klpq tests. for SGLD, i just lowered the tolerance because it looks like it's converging but needs more samples. for klpq, it's the bias issue @naesseth mentioned in #296; i upped the number of samples to be 25 and it looks like it's converging.

Let me know if you approve of my changes. If so, please merge this PR, or comment otherwise.

@akucukelbir
Copy link
Contributor Author

LGTM. I'm surprised the KLpq issue is due to bias on such a simple/small problem. Somehow I would've expected it to exhibit itself in larger models, but I guess I was mistaken. We need to edit the website, I'll make an issue after closing this PR.

@akucukelbir akucukelbir merged commit a024c5e into master Feb 28, 2017
@akucukelbir akucukelbir deleted the tests/inferences branch February 28, 2017 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants