Skip to content

Remove special case for empty matrix #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blegat wants to merge 1 commit into
base: bl/sparsematrixcol
Choose a base branch
from
+1 −17
Open

Remove special case for empty matrix #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions src/coloring.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,23 +53,6 @@ function _hessian_color_preprocess(
local_indices = sort!(collect(seen_idx))
empty!(seen_idx)

# Handle empty case (no edges in Hessian)
if isempty(local_indices)
# Return empty structure - no variables to color
# We still need to return a valid ColoringResult, but with empty local_indices
# The I and J vectors are already empty, which is correct
# For the result, we'll create a minimal valid structure with a diagonal element
# Note: This case should rarely occur in practice
S = SMC.SparsityPatternCSC(SparseArrays.spdiagm(0 => [true]))
problem = SMC.ColoringProblem(;
structure = :symmetric,
partition = :column,
)
tree_result = SMC.coloring(S, problem, algo)
result = ColoringResult(tree_result, Int[])
return I, J, result
end

global_to_local_idx = seen_idx.nzidx # steal for storage
for k in eachindex(local_indices)
global_to_local_idx[local_indices[k]] = k
Expand All @@ -91,6 +74,7 @@ function _hessian_color_preprocess(
structure = :symmetric,
partition = :column,
)
display(S)
tree_result = SMC.coloring(S, problem, algo)

# Reconstruct I and J from the tree structure (matching original _indirect_recover_structure)
Expand Down
Loading