Skip to content

Update OpenBLAS to v0.3.14 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Conversation

maoe
Copy link
Contributor

@maoe maoe commented Mar 30, 2021

Current master uses v0.3.10 when --features static is set. While it seems to work fine on macOS 10.5, it fails to build on macOS Big Sur (11.2.3) when the lapacke feature is set:

  lapacke_sggsvd_work.c:48:9: error: implicit declaration of function 'sggsvd_' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
          LAPACK_sggsvd( &jobu, &jobv, &jobq, &m, &n, &p, k, l, a, &lda, b, &ldb,
          ^
  ../include/lapack.h:3652:23: note: expanded from macro 'LAPACK_sggsvd'
  #define LAPACK_sggsvd LAPACK_GLOBAL(sggsvd,SGGSVD)
                        ^
  ../include/lapacke_mangling.h:12:39: note: expanded from macro 'LAPACK_GLOBAL'
  #define LAPACK_GLOBAL(lcname,UCNAME)  lcname##_
                                        ^
  <scratch space>:241:1: note: expanded from here
  sggsvd_
  ^
  lapacke_sggsvd_work.c:127:9: error: implicit declaration of function 'sggsvd_' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
          LAPACK_sggsvd( &jobu, &jobv, &jobq, &m, &n, &p, k, l, a_t, &lda_t, b_t,
          ^
  ../include/lapack.h:3652:23: note: expanded from macro 'LAPACK_sggsvd'
  #define LAPACK_sggsvd LAPACK_GLOBAL(sggsvd,SGGSVD)
                        ^
  ../include/lapacke_mangling.h:12:39: note: expanded from macro 'LAPACK_GLOBAL'
  #define LAPACK_GLOBAL(lcname,UCNAME)  lcname##_
                                        ^
  <scratch space>:242:1: note: expanded from here
  sggsvd_
  ^
  2 errors generated.
  make[3]: *** [lapacke_sggsvd_work.o] Error 1
  lapacke_zggsvd_work.c:51:9: error: implicit declaration of function 'zggsvd_' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
          LAPACK_zggsvd( &jobu, &jobv, &jobq, &m, &n, &p, k, l, a, &lda, b, &ldb,
          ^
  ../include/lapack.h:3681:23: note: expanded from macro 'LAPACK_zggsvd'
  #define LAPACK_zggsvd LAPACK_GLOBAL(zggsvd,ZGGSVD)
                        ^
  ../include/lapacke_mangling.h:12:39: note: expanded from macro 'LAPACK_GLOBAL'
  #define LAPACK_GLOBAL(lcname,UCNAME)  lcname##_
                                        ^
  <scratch space>:241:1: note: expanded from here
  zggsvd_
  ^
  lapacke_zggsvd_work.c:138:9: error: implicit declaration of function 'zggsvd_' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
          LAPACK_zggsvd( &jobu, &jobv, &jobq, &m, &n, &p, k, l, a_t, &lda_t, b_t,
          ^
  ../include/lapack.h:3681:23: note: expanded from macro 'LAPACK_zggsvd'
  #define LAPACK_zggsvd LAPACK_GLOBAL(zggsvd,ZGGSVD)
                        ^
  ../include/lapacke_mangling.h:12:39: note: expanded from macro 'LAPACK_GLOBAL'
  #define LAPACK_GLOBAL(lcname,UCNAME)  lcname##_
                                        ^
  <scratch space>:242:1: note: expanded from here
  zggsvd_
  ^
  2 errors generated.
  make[3]: *** [lapacke_zggsvd_work.o] Error 1
  make[2]: *** [lapacke] Error 2
  make[1]: *** [lapackelib] Error 2
  make: *** [netlib] Error 2
  thread 'main' panicked at 'Failed: `"make" "libs" "netlib" "shared" "BINARY=64" "YES_CBLAS=1" "YES_LAPACKE=1" "-j16"` (exit code: 2)', openblas-src/build.rs:247:21
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I don't really know why it fails but found that upgrading OpenBLAS source seemed to fix it. Unfortunately GitHub Actions doesn't provide Big Sur runners publicly yet so there's nothing but "it works for me" to support that this fix is correct.

Note that this PR is currently based on #61. Let me know if it should be based off of master instead.

@IvanUkhov
Copy link
Member

IvanUkhov commented Apr 2, 2021

Thank you! Yes, please remove what is covered by #61. We will discuss it separately there.

@maoe maoe force-pushed the openblas-0.3.14 branch from d2883cc to 912667a Compare April 2, 2021 12:55
@maoe
Copy link
Contributor Author

maoe commented Apr 2, 2021

Sure. Dropped the commit from #61.

@IvanUkhov IvanUkhov merged commit 9b57c79 into blas-lapack-rs:master Apr 2, 2021
@maoe maoe deleted the openblas-0.3.14 branch April 2, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants