Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert config updating and video/audio queues to use zmq #9893

Merged
merged 12 commits into from
Feb 19, 2024

Conversation

NickM-27
Copy link
Collaborator

@NickM-27 NickM-27 commented Feb 16, 2024

This PR removes the config fields in the mp.dict and the video/audio output queues in favor of using zero mq. This allows a more straightforward approach to updating data in separate processes.

As a side effect this closes #4326 because a motion config is required to hold the current state of motion detection

Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 5bec899
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/65d354fd79e1bc00086aeaf3

frigate/config.py Outdated Show resolved Hide resolved
@NickM-27 NickM-27 marked this pull request as ready for review February 18, 2024 22:00
@NickM-27 NickM-27 changed the title Convert video output and recordings info queues to use zmq Convert config updating and video/audiuo queues to use zmq Feb 18, 2024
@NickM-27 NickM-27 changed the title Convert config updating and video/audiuo queues to use zmq Convert config updating and video/audio queues to use zmq Feb 18, 2024
@blakeblackshear blakeblackshear merged commit dba21b6 into dev Feb 19, 2024
13 checks passed
@blakeblackshear blakeblackshear deleted the zmq-detected-data branch February 19, 2024 13:27
@regystro
Copy link

As a side effect this closes #4326 because a motion config is required to hold the current state of motion detection

Sorry, but I don't understand. What do I have to put in the config file to ensure a certain camera starts with motion detection disabled when frigate restarts? I want the camera to not be disabled, but start with motion and detection disabled. Detection can be disabled at startup, but cannot figure out how to start with motion disabled.

Thank you.

@NickM-27
Copy link
Collaborator Author

This isn't available in anything but the dev version, you should wait until the release when the docs are updated

@regystro
Copy link

Cool. Many thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to enable/disable motion detection from Frigate UI and frigate.yml
3 participants