-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMD GPU support with the rocm detector and YOLOv8 pretrained model download and support for edgetpu and openvino detectors #9760
Conversation
… box scaling; use cv2.dnn.blobForImage for preprocessing; assert on required model parameters
…al version as the empty value broke rocm
…ouple of known chipsets
…tensor element type
This reverts commit dcfe6bb.
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think we need to break this up, there are a lot of changes in here that would need to be discussed separately. For example, the latest openvino version does not support the ncs2. We have not given users any notice that it will be unsupported in the next frigate version so I don't think this is the right time for that. I would suggest 3 separate PRs where things can be discussed:
|
So I should delete close this PR and create a new one with limited changes for rocm only? |
That's what I would suggest, will make it easier to get merged while we consider the ramifications of some of the other changes |
Closed as suggested |
ROCm specific PR here: #9762 |
Main changes/improvements:
Possible problems: I updated openvino version to newer generic as it's needed to run the yolov8 models due to version compatibility