Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMD GPU support with the rocm detector and YOLOv8 pretrained model download and support for edgetpu and openvino detectors #9760

Closed
wants to merge 46 commits into from

Conversation

harakas
Copy link
Contributor

@harakas harakas commented Feb 9, 2024

Main changes/improvements:

  • new rocm (AMD GPUs) and onnx detector plugins
    • onnx is more of a development thing, openvino runs same/better in general for same inputs
    • currently only yolov8 models supported
    • in theory can process any "normal" onnx files, just needs proper pre and post-processing
    • does not use quantized models so runs full f32
  • yolov8 support for edgetpu detector (derived from @lkaino frigate branch)
  • better yolov8 support in openvino detector
    • latest quantized yolov8 export from ultralytics wants an f32 input image
    • openvino can now also take generic yolov8 onnx files as input and run them in full f32 mode
  • yolov8 pre- and postprocessing utility functions
  • yolov8 model automatic download using DOWNLOAD_YOLOV8 environment variable

Possible problems: I updated openvino version to newer generic as it's needed to run the yolov8 models due to version compatibility

… box scaling; use cv2.dnn.blobForImage for preprocessing; assert on required model parameters
Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 7237a79
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/65c6186f1cef0900088e8e4b
😎 Deploy Preview https://deploy-preview-9760--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NickM-27
Copy link
Collaborator

NickM-27 commented Feb 9, 2024

I think we need to break this up, there are a lot of changes in here that would need to be discussed separately. For example, the latest openvino version does not support the ncs2. We have not given users any notice that it will be unsupported in the next frigate version so I don't think this is the right time for that.

I would suggest 3 separate PRs where things can be discussed:

  • RocM
  • edgetpu
  • openvino

@harakas
Copy link
Contributor Author

harakas commented Feb 9, 2024

So I should delete close this PR and create a new one with limited changes for rocm only?

@NickM-27
Copy link
Collaborator

NickM-27 commented Feb 9, 2024

That's what I would suggest, will make it easier to get merged while we consider the ramifications of some of the other changes

@harakas
Copy link
Contributor Author

harakas commented Feb 9, 2024

Closed as suggested

@harakas harakas closed this Feb 9, 2024
@harakas
Copy link
Contributor Author

harakas commented Feb 9, 2024

ROCm specific PR here: #9762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants