-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to override go2rtc binary in add-on #5876
Allow to override go2rtc binary in add-on #5876
Conversation
👷 Deploy Preview for frigate-docs processing.
|
✅ Deploy Preview for frigate-docs canceled.
|
I think we may run into a problem with users who are also running the webrtc card v3 and have not pointed it at frigate. Depends how that version of go2rtc binary gets named |
Some alternative ideas then:
WDYT? |
Looks like |
Just tested, works fine for me in a docker container as well which makes it easier |
Sorry to post on a closed PR, but how do I override the embedded go2rtc version while using the add-on? |
Place the go2rtc file called go2rtc in /config |
And ensure it has execution permission. |
This adds a feature from the go2rtc add-on to the Frigate add-on:
This is motived by this comment:
Which says that users can override go2rtc through bind mounts, but that's unfortunately not available to add-on users like me.
I'm happy to make changes if needed.