Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System page: various minor UI tweaks #4985

Merged
merged 4 commits into from
Jan 11, 2023
Merged

System page: various minor UI tweaks #4985

merged 4 commits into from
Jan 11, 2023

Conversation

leccelecce
Copy link
Contributor

First PR, thank you for the excellent software!

Per discussion with Nick M on #4978, this is a tiny PR to implement some minor UI changes to the System page. These were changes I could make without rebuilding core; there are more suggested changes on the discussion thread that would require backend changes as well which I will send a PR for separately once I have everything set up.

Changes:

-Add a CPU% column to the Detectors cards. I have tested this with CPU detectors and OpenVINO in CPU mode. I don't have the ability to run a GPU detector at present, so would appreciate a test by someone to ensure it doesn't break anything (it shouldn't).
-Added "ms" after inference speed value to make it clear what the number means
-Capitalized FPS, CPU acronyms
-Reordered per-camera table to follow data flow of ffmpeg => capture => detect

@netlify
Copy link

netlify bot commented Jan 9, 2023

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 8ab151a
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/63bd59eacbdecb0007de8955

Copy link
Collaborator

@NickM-27 NickM-27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tried it and seems fine with corals as well, I think it should make sense to just leave this % in for all detectors as it may be useful

Screen Shot 2023-01-09 at 17 03 50 PM

web/src/routes/System.jsx Show resolved Hide resolved
web/src/routes/System.jsx Show resolved Hide resolved
@blakeblackshear
Copy link
Owner

Do we still think the detection start time is useful here? I'm not sure it is.

@NickM-27
Copy link
Collaborator

I think like in the discussion linked above it might be more useful if it shows a state like idle or "started x milliseconds ago" but yeah not sure it's needed for most cases

@leccelecce
Copy link
Contributor Author

I just experimented with this a bit and I'm struggling to get an obviously useful statistic out of the last detection start time if I calculate now() - start it in the front end, I'm guessing because the stats are updating periodically on the server and so the last start time might be ~ 10 seconds out of date by the time the front end refreshes.

In the short term, I have just changed it in the UI to be 'running' or 'idle', sample below.

image

As I'm planning a separate PR with some more tweaks that require server side changes, I will look at revisiting this to provide a "started X ms ago"/"idle" instead of "running"/"idle" if that's what you would prefer.

@leccelecce
Copy link
Contributor Author

One interesting thing the last change highlights is that it's often possible for no detection to be running, but CPU to still be high. I'm guessing that's because the top command for CPU util is not by nature exactly aligned to the detection code, or possibly that the CPU has a bit more work to do after the detection timer finishes. For that reason it might be more useful under Detection Status to have a "detections last 1s" or similar?

@blakeblackshear
Copy link
Owner

I was suggesting just removing it. It's going to flip back and forth between running and idle so frequently, I am not sure it means much. Frigate is already watching and restarts the detection process with log messages if needed.

@leccelecce
Copy link
Contributor Author

leccelecce commented Jan 10, 2023

Removed! Now just:

image

@NickM-27
Copy link
Collaborator

Looks good to me 👍

@blakeblackshear blakeblackshear merged commit acd1fb9 into blakeblackshear:dev Jan 11, 2023
@leccelecce leccelecce deleted the system_ui_tweaks_1 branch January 11, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants