-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System page: various minor UI tweaks #4985
System page: various minor UI tweaks #4985
Conversation
✅ Deploy Preview for frigate-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still think the detection start time is useful here? I'm not sure it is. |
I think like in the discussion linked above it might be more useful if it shows a state like |
I just experimented with this a bit and I'm struggling to get an obviously useful statistic out of the last detection start time if I calculate now() - start it in the front end, I'm guessing because the stats are updating periodically on the server and so the last start time might be ~ 10 seconds out of date by the time the front end refreshes. In the short term, I have just changed it in the UI to be 'running' or 'idle', sample below. As I'm planning a separate PR with some more tweaks that require server side changes, I will look at revisiting this to provide a "started X ms ago"/"idle" instead of "running"/"idle" if that's what you would prefer. |
One interesting thing the last change highlights is that it's often possible for no detection to be running, but CPU to still be high. I'm guessing that's because the |
I was suggesting just removing it. It's going to flip back and forth between running and idle so frequently, I am not sure it means much. Frigate is already watching and restarts the detection process with log messages if needed. |
Looks good to me 👍 |
First PR, thank you for the excellent software!
Per discussion with Nick M on #4978, this is a tiny PR to implement some minor UI changes to the System page. These were changes I could make without rebuilding core; there are more suggested changes on the discussion thread that would require backend changes as well which I will send a PR for separately once I have everything set up.
Changes:
-Add a CPU% column to the Detectors cards. I have tested this with CPU detectors and OpenVINO in CPU mode. I don't have the ability to run a GPU detector at present, so would appreciate a test by someone to ensure it doesn't break anything (it shouldn't).
-Added "ms" after inference speed value to make it clear what the number means
-Capitalized FPS, CPU acronyms
-Reordered per-camera table to follow data flow of ffmpeg => capture => detect