Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite encoding logic and cleanup vaapi presets #4898

Merged
merged 6 commits into from
Jan 5, 2023

Conversation

NickM-27
Copy link
Collaborator

@NickM-27 NickM-27 commented Jan 4, 2023

  • No need for two vaapi presets when they are the same, moving to preset-vaapi
  • Remove vaapi hardware encoding since it is buggy for this rawvideo yuv420p encoding to rtsp (works for mp4, not rtsp)

@netlify
Copy link

netlify bot commented Jan 4, 2023

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit fc6e9a1
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/63b5acc7b58fc500083de097

@NickM-27 NickM-27 marked this pull request as draft January 4, 2023 16:19
@NickM-27
Copy link
Collaborator Author

NickM-27 commented Jan 4, 2023

The vaapi encoder has a lot of performance issues and I think it will not be reliable for use with RTSP, should just use the software encoder when vaapi is set

@NickM-27 NickM-27 marked this pull request as ready for review January 4, 2023 16:44
@blakeblackshear blakeblackshear merged commit 0a3295a into blakeblackshear:dev Jan 5, 2023
@NickM-27 NickM-27 deleted the vaapi-encoding branch January 5, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants