Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recommended hardware page to reflect multiple detectors #4746

Merged
merged 12 commits into from
Dec 31, 2022

Conversation

NickM-27
Copy link
Collaborator

@NickM-27 NickM-27 commented Dec 19, 2022

No description provided.

@netlify
Copy link

netlify bot commented Dec 19, 2022

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 251f862
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/63af028454a6410008ec77e3
😎 Deploy Preview https://deploy-preview-4746--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NickM-27 NickM-27 changed the title Update recommended hardware page to reflect multiple detectors are su… Update recommended hardware page to reflect multiple detectors Dec 19, 2022
@NickM-27 NickM-27 marked this pull request as draft December 19, 2022 21:14
@NickM-27
Copy link
Collaborator Author

@NateMeyer Let me know what you think, the J4105 and VPU examples are pulled from your post and the N4020 is from a personal laptop I use for occasional intel testing. Does more information need to be provided for OpenVino side?

Copy link
Contributor

@NateMeyer NateMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. A couple suggestions.

docs/docs/frigate/hardware.md Show resolved Hide resolved
docs/docs/frigate/hardware.md Outdated Show resolved Hide resolved

### TensorRT

The TensortRT detector is able to run on x86 hosts that have an Nvidia GPU.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will probably be a minimum compatible generation of GPU. We'll have to figure out what this is in the TensorRT PR and update this section.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly would probably want a note on this page for the OpenVino as well (I believe it is listed on the other docs)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would be good to mention here as well. Can we also put in a link to the detector doc page sections?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I reorganized the docs a bit so there aren't so many ands and ors

@NickM-27 NickM-27 marked this pull request as ready for review December 31, 2022 15:20
@blakeblackshear blakeblackshear merged commit 9c6193b into blakeblackshear:dev Dec 31, 2022
@NickM-27 NickM-27 deleted the rec-hardware branch January 11, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants