Custom notifications suspend duration UI by smaugfm · Pull Request #23286 · blakeblackshear/frigate

smaugfm · 2026-05-22T09:24:53Z

Proposed change

Adds a cemera notifications suspension dialog to enter custom suspension time.
Addresses a comment from my rejected PR.

This one is much simpler, only UI changes.
CustomSuspensionDialog itself turned out quiet big because of the validations & defensive programming .

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New feature
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code
Documentation Update

For new features

I did search for the existing requests and haven't found anything similar to this. I haven't started a discussion as I would've implemented this feature for my needs anyway, and I might as well suggest a PR.

AI disclosure

No AI tools were used in this PR.
AI tools were used in this PR. Details below:

AI tool(s) used : Claude Code

How AI was used: code generation, code review, and debugging.

Extent of AI involvement: generated the entire implementation.

Human oversight: Review/manual fixes/iterations of changes over generated code, tested UI manually.

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I can explain every line of code in this PR if asked.
UI changes including text have used i18n keys and have been added to the en locale.
The code has been formatted using Ruff (ruff format frigate)

NickM-27

Overall I think this looks fine, but the radix comment and logic is overcomplicated and I don't think it is needed.

hawkeye217 · 2026-05-22T14:46:40Z

Thanks for the PR, there are a number of issues that would need to be addressed before we would consider merging.

I would suggest dropping the Duration tab entirely. Most apps with "snooze for N" pickers just present clock time, and Frigate already has presets for common durations.
For the "Until" view, you should be using TimezoneAwareCalendar and useFormattedTimestamp rather than rebuilding an entirely separate implementation. Just follow the codebase's existing conventions in CustomTimeSelector.
You should compute totalMinutes at the click, not via useMemo.
The dialog should be triggered from either a sibling button (or the context menu item) so that the Select doesn't need to have a "fake" custom value.
Your AI added far too many comments in the code, as @NickM-27 mentioned, these are unnecessary.
In the i18n changes, use 3 periods (...) rather than a unicode character.

smaugfm · 2026-05-23T19:26:47Z

@NickM-27 & @hawkeye217
Thanks for the feedback. Addressed your concerns, please take a look.

Took the liberty of using Dropdown with a style matching Select instead of creating a "sibling" button (not sure what you meant by that, tried creating a button just alongside the Select - looked bad IMO).

hawkeye217 · 2026-05-23T20:20:02Z

+          <DropdownMenuTrigger
+            className={cn(selectTriggerClassName, "w-auto gap-2")}
+          >
+            {t("notification.suspendTime.suspend")}
+            <LuChevronDown className="h-4 w-4 opacity-50" />
+          </DropdownMenuTrigger>


Suggested change

<DropdownMenuTrigger

className={cn(selectTriggerClassName, "w-auto gap-2")}

>

{t("notification.suspendTime.suspend")}

<LuChevronDown className="h-4 w-4 opacity-50" />

</DropdownMenuTrigger>

<DropdownMenuTrigger asChild>

<Button size="sm" variant="outline" className="flex gap-2">

{t("notification.suspendTime.suspend")}

<LuChevronDown className="h-4 w-4 opacity-50" />

</Button>

</DropdownMenuTrigger>

A dropdown is fine, but just use a <Button> like the rest of the codebase does. No need to modify the select.tsx component for this.

hawkeye217 · 2026-05-23T20:20:29Z

+  DropdownMenuSeparator,
+  DropdownMenuTrigger,
+} from "@/components/ui/dropdown-menu";
+import { selectTriggerClassName } from "@/components/ui/select";


Suggested change

import { selectTriggerClassName } from "@/components/ui/select";

This line can be deleted.

hawkeye217 · 2026-05-23T20:21:04Z

All the changes in this file can be reverted if you use a <Button> as I suggested.

hawkeye217 · 2026-05-23T20:21:54Z

  return (
    <div className={cn("w-full", className)}>
-      <ContextMenu key={camera} onOpenChange={handleOpenChange}>
+      <ContextMenu key={camera} modal={false} onOpenChange={handleOpenChange}>


Suggested change

<ContextMenu key={camera} modal={false} onOpenChange={handleOpenChange}>

<ContextMenu key={camera} onOpenChange={handleOpenChange}>

Your AI shouldn't have added this here.

NickM-27 · 2026-05-24T13:36:58Z

  "initializeCommand": ".devcontainer/initialize.sh",
  "postCreateCommand": ".devcontainer/post_create.sh",
  "overrideCommand": false,
-  "remoteUser": "vscode",


I don't think this should be removed, especially not in this PR

Sorry, accidentally committed changes for IntelliJ IDEA to work with the dev container. Removed

NickM-27 · 2026-05-24T13:37:15Z

-sudo chown -R "$(id -u):$(id -g)" /media/frigate
+SUDO=""
+if [[ $EUID -ne 0 ]]; then
+  SUDO="sudo"


Same as above, unrelated change

Sorry, accidentally committed changes for IntelliJ IDEA to work with the dev container. Removed

NickM-27 · 2026-06-07T12:05:52Z

Looks like this still needs to be removed from the commit

smaugfm and others added 3 commits May 17, 2026 08:50

Add custom notification suspension dialog

0d05f0f

Merge branch 'blakeblackshear:dev' into dev

597a9f9

Improve on the dialog, fix some bugs

263554a

NickM-27 reviewed May 22, 2026

View reviewed changes

smaugfm added 2 commits May 23, 2026 21:32

Review changes

df40d9e

Make Dropdown look like Select

bf25560

smaugfm requested a review from NickM-27 May 23, 2026 19:20

hawkeye217 requested changes May 23, 2026

View reviewed changes

Review changes

8f6e083

smaugfm force-pushed the dev branch from dacae4f to 8f6e083 Compare May 24, 2026 04:45

smaugfm requested a review from hawkeye217 May 24, 2026 05:02

NickM-27 requested changes May 24, 2026

View reviewed changes

Remove accidential changes

51dd890

smaugfm force-pushed the dev branch from 80a20e5 to 51dd890 Compare June 7, 2026 05:07

smaugfm requested a review from NickM-27 June 7, 2026 05:07

Merge branch 'dev' into dev

f00dd5c

NickM-27 reviewed Jun 7, 2026

View reviewed changes

Comment thread .devcontainer/post_create.sh

NickM-27 Jun 7, 2026

Copy link
Copy Markdown

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this still needs to be removed from the commit

	<ContextMenu key={camera} modal={false} onOpenChange={handleOpenChange}>
	<ContextMenu key={camera} onOpenChange={handleOpenChange}>

Uh oh!

Conversation

smaugfm commented May 22, 2026

Proposed change

Type of change

For new features

AI disclosure

Checklist

Uh oh!

NickM-27 left a comment

Choose a reason for hiding this comment

Uh oh!

hawkeye217 commented May 22, 2026

Uh oh!

smaugfm commented May 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants