Restrict go2rtc exec sources by default #21543
Merged
+66
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
go2rtc supports
exec,expr, andechosources which can be used to execute arbitrary code. This makes it particularly easy for an attacker to gain extra access and run arbitrary programs such as crypto miners once they have access to a user's config.This PR makes it so the parser restricts these streams by default unless an env var is set to override that behavior, making it less likely that a user can be affected by this manner of attack.
Type of change
Checklist
enlocale.ruff format frigate)