UI tweaks #10998
Merged
UI tweaks #10998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NickM-27
commented
Apr 16, 2024
•
NickM-27
commented
- make sidebar items consistent
- add hover state to sidebar items
- use switches for camera selector to be consistent
- use green color for general graphs by default
- fix pydantic warnings
- fix logs icon and tab name
✅ Deploy Preview for frigate-docs canceled.
|
hawkeye217
approved these changes
Apr 16, 2024
mweinelt
reviewed
Apr 17, 2024
| wsdl_dir=Path(find_spec("onvif").origin).parent / "../wsdl", | ||
| wsdl_dir=str( | ||
| Path(find_spec("onvif").origin).parent / "wsdl" | ||
| ).replace("dist-packages/onvif", "site-packages"), |
There was a problem hiding this comment.
Hm, ok. That breaks for me, given that the onvif package lands in site-packages in my environment. Need to put some more thought into this.
/nix/store/0q055hskam5ihnrhxxk6s3rgw376fpjq-python3-3.11.8-env/lib/python3.11/site-packages/onvif/wsdl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.