Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI changes #10651

Merged
merged 2 commits into from
Mar 24, 2024
Merged

UI changes #10651

merged 2 commits into from
Mar 24, 2024

Conversation

hawkeye217
Copy link
Collaborator

@hawkeye217 hawkeye217 commented Mar 24, 2024 •
edited
Loading

  • Because motion scrubbing moves ~6-7s per pixel, a review item of a duration less than that (like a fast moving car) would prevent an outline from appearing around a camera in motion review. The fix is to check if the event's time is anywhere within the full segment.
  • Optimize getSeverity calculation for timelines to only go through the review items array once.
  • Conditionally render minimap bounds in timelines.
  • Playground changes for 24h timelines for testing performance.

@netlify Netlify
Copy link

netlify bot commented Mar 24, 2024 •
edited
Loading

✅ Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit a7f70aa
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/660062db2accba00082f3e7e

@NickM-27 NickM-27 merged commit 37f60f7 into dev Mar 24, 2024
13 checks passed
@NickM-27 NickM-27 deleted the event-time-check branch March 24, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickM-27 NickM-27 NickM-27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawkeye217 @NickM-27