Timeline minimap and scrolling changes #10589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hawkeye217
commented
Mar 21, 2024
•
hawkeye217
commented
- Add hook function to get visible timeline duration
- Only show minimap if visible review items fit within visible timeline
- More intelligently scroll timeline when minimap is hidden - don't scroll again after hovering preview unless preview area is scrolled by the user
✅ Deploy Preview for frigate-docs canceled.
|
…lackshear/frigate into visible-timeline-duration
hawkeye217
changed the title
NickM-27
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.