-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Home Assistant media viewer for new Frigate versions #518
Fix Home Assistant media viewer for new Frigate versions #518
Conversation
94f66c5
to
ae64c65
Compare
@NickM-27 Do these old references in frigate need to be updated as well? |
No those are all correct, all of those are different to the event DB structure (which comes from the API) |
Even maintainer.py:31? Those are |
They are just labeled that way because mypy requires a label, they are actually just a dict and come from here https://github.com/blakeblackshear/frigate/blob/f2ff55dba2c8548fedca3f4a4a3da7d7a5feaaf8/frigate/object_processing.py#L264 so yes it is correct |
@madsciencetist Mind fixing up the tests and we can get this in? Thanks in advance! |
blakeblackshear/frigate#6320 changed the events API to move box, region, score and top_score into a "data" sub-struct
ae64c65
to
22bf17a
Compare
Fixed |
Codecov Report
@@ Coverage Diff @@
## dev #518 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1929 1936 +7
=========================================
+ Hits 1929 1936 +7
|
@madsciencetist Almost! Looks like formatting isn't quite right, run the precommit manually and commit/push the changes? |
Might I suggest that you not require workflow approval, so that CI failures are immediately evident! |
I'll counter-suggest installing the precommit in your local client with |
Thanks @madsciencetist ! |
blakeblackshear/frigate#6320 changed the events API to move
box
,region
,score
andtop_score
into a "data" sub-struct