chore: ci fix #10
chore: ci fix #10
Conversation
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
| func Run(ctx context.Context, getenv func(string) string) error { | ||
| ctx, cancel := signal.NotifyContext(ctx, os.Interrupt) | ||
| defer cancel() |
There was a problem hiding this comment.
The signal.NotifyContext function is used to create a context that is canceled when an interrupt signal is received. However, the os.Interrupt signal is not the only signal that might require the application to gracefully shut down. Consider handling other termination signals like os.Kill and syscall.SIGTERM to ensure the application can handle a broader range of termination scenarios.
| return core.ConsumeActivity(ctx, nc, Name, []string{"activity.gaming"}, func(msg jetstream.Msg) error { | ||
| var event *events.PresenceUpdate | ||
| err := json.Unmarshal(msg.Data(), &event) |
There was a problem hiding this comment.
The json.Unmarshal function is used to decode the message data into the event variable. However, the event variable is declared as a pointer (*events.PresenceUpdate), but it is not initialized. This can lead to a nil pointer dereference if the json.Unmarshal fails. Ensure that the event variable is properly initialized before unmarshaling the JSON data.
No description provided.