Conversation
BREAKING FIX: hooksPostEdit, hooksPostTask, and hooksPostCommand were
returning success without actually storing any data. This fix makes
them call getRealStoreFunction() to persist to the memory database.
Changes:
- hooksPostEdit: Now stores to 'patterns' namespace with HNSW indexing
- hooksPostTask: Now stores to 'trajectories' namespace with HNSW indexing
- hooksPostCommand: Now stores to 'commands' namespace with HNSW indexing
- getLearningStats: Now queries real SELECT COUNT(*) instead of file_size/2KB
Before:
- handlers returned {recorded: true} without database INSERT
- hooksPostTask returned Math.random() for duration (fake data)
- statusline showed file_size/2KB as "patterns" count (misleading)
After:
- handlers call storeEntry() with generateEmbeddingFlag: true
- real pattern IDs returned from database
- statusline queries actual table row counts
Verified:
- ✅ post-edit: PERSISTED - "Pattern stored with HNSW indexing"
- ✅ post-task: PERSISTED - "Trajectory stored with HNSW indexing"
- ✅ post-command: PERSISTED - "Command pattern stored with HNSW indexing"
Closes ruvnet#1058
(cherry picked from commit 2e32f85)
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Integration Test Results🔗 Cross-Agent Integration Test ReportSession ID: integration-20260206-224337-1fbfd175edb84914abb513907a3b3481e0a0d7aa Summary
Test Results
Recommendations
Next Steps
Generated by Cross-Agent Integration Test Pipeline |
2 participants
Replica upstream
Questa PR ricrea nel fork la fix upstream:
Contenuto
hooksPostEdit,hooksPostTask,hooksPostCommand) passano da stub a persistenza reale su DBpatterns,trajectories,commands)Metodo
Cherry-pick del commit upstream
2e32f852c1dd057b3a190f550a1c82d7db7541a3(con-x).