Update required meson build #1937
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: previous 1.0 builds might work as well. I have only tested with latest today (1.5.1). Fixes blackmagic-debug#1933
dragonmux
requested changes
Sep 20, 2024
| @@ -114,7 +114,7 @@ use the `/dev/tty.usbmodemXXX` device node involving how it operates under the h | |||
| When developing this project, the following tools are required: | |||
|
|
|||
| * [git](https://git-scm.com) | |||
| * [meson](https://mesonbuild.com/Getting-meson.html) (version 0.61 or greater) | |||
| * [meson](https://mesonbuild.com/Getting-meson.html) (version 1.5.1 or greater) | |||
There was a problem hiding this comment.
We've had it confirmed by another contributor that v1.1.1 also works. The changelog suggests that it was fixed in 0.63. Given this, let's bump the Meson requirement here to just 0.63 and see if anyone else complains with at least that. Think saying 1.5.1 as it's the latest release is a little too strict.
There was a problem hiding this comment.
Note that bumping the meson version requirement should be done in the main meson.build first, there it'll produce a warning even for those who won't look at the readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
Documentation update to requirements. Fixes #1933 Ubuntu 22.04 compilation issue: "error: ‘O_CLOEXEC’ undeclared (first use in this function); did you mean ‘FD_CLOEXEC’?" caused by default
mesonAPT install on Ubuntu 22.Note: previous meson (1.0?) builds might work as well. I have only tested with latest today (1.5.1).
Your checklist for this pull request
Closing issues
Fixes #1933