Skip to content

Conversation

@ocervell
Copy link
Contributor

@ocervell ocervell commented Feb 7, 2025

This removes the unecessary need for the whole ansible library, replacing it with ansible-core library.

This saves about 300MB of disk space when installing bbot.

2025-02-07 11_34_46-Debian 12 - VMware Workstation
2025-02-07 11_34_30-Debian 12 - VMware Workstation

Fixes #2257

@TheTechromancer
Copy link
Collaborator

bruh

@TheTechromancer TheTechromancer self-assigned this Feb 8, 2025
@TheTechromancer
Copy link
Collaborator

Hmm, at least one of the dependencies is failing to install. From the output it's not clear which one; I'll see about improving the error message. #2268

@TheTechromancer TheTechromancer changed the base branch from stable to dev February 13, 2025 00:34
@TheTechromancer
Copy link
Collaborator

Still doing some troubleshooting. This is a nice change, which I'd like to get merged soon.

@TheTechromancer
Copy link
Collaborator

Looks like wpscan is our culprit:

DEBUG    bbot.core.helpers.depsinstaller:installer.py:341 Ansible status: failed
DEBUG    bbot.core.helpers.depsinstaller:installer.py:342 Ansible return code: 4
DEBUG    bbot.core.helpers.depsinstaller:installer.py:347 {
  "event": "verbose",
  "uuid": "9e23c5df-22bc-4372-8455-e444cda8ed9e",
  "counter": 1,
  "stdout": "ERROR! couldn't resolve module/action 'gem'. This often indicates a misspelling, missing collection, or incorrect module path.",
  "start_line": 0,
  "end_line": 1,
  "runner_ident": "6c607a80-c869-4a3f-b4d1-9d8cdf713f17",
  "created": "2025-02-20T18:36:05.293847+00:00"
}

Working on a fix.

@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (4764d3b) to head (c12aa15).
Report is 11 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/cli.py 60% 2 Missing ⚠️
bbot/core/helpers/depsinstaller/installer.py 82% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2259   +/-   ##
=====================================
- Coverage     93%     93%   -0%     
=====================================
  Files        380     380           
  Lines      29751   29761   +10     
=====================================
+ Hits       27513   27519    +6     
- Misses      2238    2242    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer merged commit ea34dc5 into blacklanternsecurity:dev Feb 21, 2025
14 checks passed
@ocervell
Copy link
Contributor Author

ocervell commented Mar 3, 2025

Congrats for this !!! Will be much better. It's ALWAYS wpscan =D

liquidsec pushed a commit that referenced this pull request Jun 13, 2025
Remove Ansible but keep ansible-core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider using ansible-core instead of ansible to reduce install size significantly

3 participants