Skip to content

URL sanitization error fix #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Dev -> Stable 2.7.2
merged 3 commits into from
Oct 2, 2024
Merged

URL sanitization error fix #1709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1d5498
add test
invalid-email-address Aug 27, 2024
d50def2
Merge branch 'dev' into sanitization-error-fix
TheTechromancer Oct 2, 2024
b713d85
improved yara full url regex
liquidsec Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bbot/modules/internal/excavate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ async def process(self, yara_results, event, yara_rule_settings, discovery_conte

class URLExtractor(ExcavateRule):
yara_rules = {
"url_full": r'rule url_full { meta: tags = "spider-danger" description = "contains full URL" strings: $url_full = /https?:\/\/([\w\.-]+)([:\/\w\.-]*)/ condition: $url_full }',
"url_full": r'rule url_full { meta: tags = "spider-danger" description = "contains full URL" strings: $url_full = /https?:\/\/([\w\.-]+)(:\d{1,5})?([\/\w\.-]*)/ condition: $url_full }',
"url_attr": r'rule url_attr { meta: tags = "spider-danger" description = "contains tag with src or href attribute" strings: $url_attr = /<[^>]+(href|src)=["\'][^"\']*["\'][^>]*>/ condition: $url_attr }',
}
full_url_regex = re.compile(r"(https?)://((?:\w|\d)(?:[\d\w-]+\.?)+(?::\d{1,5})?(?:/[-\w\.\(\)]*[-\w\.]+)*/?)")
Expand Down
2 changes: 1 addition & 1 deletion bbot/test/test_step_2/module_tests/test_module_excavate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ async def setup_before_prep(self, module_test):
\\nhttps://www1.test.notreal
\\x3dhttps://www2.test.notreal
%0ahttps://www3.test.notreal
\\u000ahttps://www4.test.notreal
\\u000ahttps://www4.test.notreal:
\nwww5.test.notreal
\\x3dwww6.test.notreal
%0awww7.test.notreal
Expand Down
Loading