Additional logging around packages.config paths during project inspection #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantyk
changed the title
shantyk
commented
Feb 5, 2025
| Console.WriteLine($"Unable to find packages config file: {Options.PackagesConfigPath}. Checking if file permissions were denied..."); | ||
| CheckFilePermissions(Options.PackagesConfigPath); | ||
| } | ||
|
|
There was a problem hiding this comment.
This addition is to check the theory that file permissions could be an issue.
shantyk
commented
Feb 5, 2025
| @@ -364,6 +389,7 @@ public bool IsExcluded() | |||
|
|
|||
| private string CreateProjectPackageConfigPath(string projectDirectory) | |||
| { | |||
| Console.WriteLine($"Creating packages.config path from project directory: {projectDirectory}"); | |||
| return PathUtil.Combine(projectDirectory, "packages.config"); | |||
There was a problem hiding this comment.
This addition is to check/highlight the theory that the file path origin could be the issue.
…ining customer logs + check for file permissions in relevant places.
shantyk
force-pushed
the
dev/shanty/IDETECT-4588-debugging
branch
from
e30b3a4 to
a91fdf1
Compare
shantyk
commented
Feb 20, 2025
| @@ -116,11 +116,16 @@ public Container GetContainer() | |||
| .Where(group => group.Count() > 1) | |||
| .Select(group => group.Key); | |||
|
|
|||
| Console.WriteLine("Processing project files found in solution file."); | |||
There was a problem hiding this comment.
I suspect the problem has to do with the project paths given in their solution file, added further logging in this area to check that (included in exe attached to ticket on Feb 20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to debug an issue that is only producible on user's system, this branch adds some logging around parts of the code that are relevant for packages.config inspection. The output logs hope to shine light on what could be causing the issue and is just testing a couple of theories.
Steps to run NuGet Inspector standalone in an IDE where debugging is not limited to the log msgs in this MR: (recommended)
Clone this repo and checkout this branch (or download the ZIP)
Open it in your favourite IDE (for example Rider)
Edit your run configurations to set the following program arguments:
--target_path=/path/to/your/nuget/project (same as detect.source.path)
--output_directory=/path/to/output/dir (this is where you will see a JSON file that summarizes the dependencies found)
--excluded_modules=PackageExplorer,Core,Types
Run it as is to see what additional info the added logs can shine light on OR run it in debug mode for a deeper dive. (potentially with someone from the Detect development team)
Steps to run NuGet Inspector standalone from source:
Clone this repo and checkout this branch (or download the ZIP)
Run
dotnet publish -c Release -r win-x64 --self-contained trueNavigate to the publish folder (will be given in the above commands output)
Run the detect-nuget-inspector.exe with the following arguments:
--target_path=/path/to/your/nuget/project (same as detect.source.path)
--output_directory=/path/to/output/dir (this is where you will see a JSON file that summarizes the dependencies found)
--excluded_modules=PackageExplorer,Core,Types
This option is limited to only output the logs added in this MR.