Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing 403 forbidden in test_openaccess_scraper #92

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Fixing 403 forbidden in test_openaccess_scraper #92

merged 4 commits into from
Apr 16, 2024

Conversation

jamesbraza
Copy link
Collaborator

@jamesbraza jamesbraza commented Apr 16, 2024 •
edited
Loading

  • Decomposed search_pdf_link to a utility function and a test
  • Removed flaky URL from CI that caused 403 errors
  • Fixed test test_link2_to_pdf_that_can_raise_403 broken by Documenting max Google pagination size #91 not always throwing a RuntimeError

@jamesbraza jamesbraza added the bug Something isn't working label Apr 16, 2024
@jamesbraza jamesbraza self-assigned this Apr 16, 2024
@jamesbraza jamesbraza merged commit 20df90f into main Apr 16, 2024
1 check passed
@jamesbraza jamesbraza deleted the fixing-ci branch April 16, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mskarlin mskarlin mskarlin approved these changes

@blackadad blackadad Awaiting requested review from blackadad

Assignees

@jamesbraza jamesbraza

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @mskarlin