Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing misleading failure message in find_pmc_pdf_link #72

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

jamesbraza
Copy link
Collaborator

https://github.com/blackadad/paper-scraper/actions/runs/8620164682/job/23626483846?pr=71

E               RuntimeError: No paper with pmc id 5008462. https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5008462 403

Similar to #71, this PR fixes another misleading failure message

It also fixes a SIM105 mix up with pre-commit during #71

@jamesbraza jamesbraza added the bug Something isn't working label Apr 9, 2024
@jamesbraza jamesbraza self-assigned this Apr 9, 2024
Copy link
Collaborator

@mskarlin mskarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting there 💪 !!

@jamesbraza jamesbraza merged commit fc64a6c into main Apr 9, 2024
1 check passed
@jamesbraza jamesbraza deleted the better-pubmed-to-pdf-failure branch April 9, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants