Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better stack trace for bibtex link failure #63

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Better stack trace for bibtex link failure #63

merged 2 commits into from
Apr 8, 2024

Conversation

jamesbraza
Copy link
Collaborator

In the event of a bibtex link traversal failure, it's nice to immediately see the paper metadata we failed upon. This PR:

  • Uses Exception.__cause__ for a richer stack trace, regardless of 443 or not
  • Cleans up GET to have separate params

@jamesbraza jamesbraza added the enhancement New feature or request label Apr 8, 2024
@jamesbraza jamesbraza self-assigned this Apr 8, 2024
mskarlin
mskarlin approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@mskarlin mskarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks helpful!

@jamesbraza jamesbraza merged commit f5a8a23 into main Apr 8, 2024
1 check failed
@jamesbraza jamesbraza deleted the easier-exception branch April 8, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mskarlin mskarlin mskarlin approved these changes

@blackadad blackadad Awaiting requested review from blackadad

Assignees

@jamesbraza jamesbraza

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @mskarlin