Fixing incorrect session for Semantic Scholar no-year #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
commented
Apr 1, 2024
| f"{title} | {year} not found. Now trying without year" | ||
| ) | ||
| del local_p["year"] | ||
| async with ss_sub_session.get( |
There was a problem hiding this comment.
This line here is the bug. Note in left it was ss_session, here it's ss_sub_session
jamesbraza
force-pushed
the
fixing-bad-session
branch
from
2f54f46
to
cdfd613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If doing a no-year search, we accidentally used the Google session, not the Semantic Scholar session.
While I was at it, I accommodated a SIM102 and dedented after
response/resp.ok's.