Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulating scraping from a_search_papers to Scrape itself #36

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Encapsulating scraping from a_search_papers to Scrape itself #36

merged 5 commits into from
Mar 13, 2024

Conversation

jamesbraza
Copy link
Collaborator

  • Decomposed batch scraping logic to Scraper itself, for better encapsulation and caller usage
  • Better documented Scraper.scrape

@blackadad blackadad merged commit f44f2a6 into blackadad:main Mar 13, 2024
1 check failed
@jamesbraza jamesbraza deleted the decomposing-scraping branch March 13, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackadad blackadad blackadad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @blackadad