Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcf improvements and fixes #125

Merged
merged 12 commits into from
Feb 18, 2022
Merged

Vcf improvements and fixes #125

merged 12 commits into from
Feb 18, 2022

Conversation

charlesgregory
Copy link
Contributor

Let me know what you think and if there is anything else I should add in.

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #125 (0dff527) into develop (2bfaf32) will decrease coverage by 0.45%.
The diff coverage is 67.24%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #125      +/-   ##
===========================================
- Coverage    85.85%   85.40%   -0.46%     
===========================================
  Files           43       43              
  Lines         3895     4151     +256     
===========================================
+ Hits          3344     3545     +201     
- Misses         551      606      +55     
Impacted Files Coverage Δ
source/dhtslib/tabix.d 78.66% <53.84%> (-5.95%) ⬇️
source/dhtslib/vcf/reader.d 94.11% <60.00%> (-3.39%) ⬇️
source/dhtslib/vcf/record.d 87.56% <65.68%> (-3.93%) ⬇️
source/dhtslib/vcf/writer.d 93.71% <75.00%> (-6.29%) ⬇️
source/dhtslib/bed/reader.d 100.00% <100.00%> (ø)
source/dhtslib/gff/reader.d 96.61% <100.00%> (ø)
source/dhtslib/vcf/header.d 95.61% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bfaf32...0dff527. Read the comment docs.

@jblachly
Copy link
Member

LGTM

@charlesgregory charlesgregory merged commit 9793888 into develop Feb 18, 2022
@charlesgregory charlesgregory deleted the vcf_fixes_and_gt branch February 18, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants