305 empty space french #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spahrson
force-pushed
the
305-empty-space-french
branch
from
30856f3
to
0b234d4
Compare
caebr
reviewed
Aug 4, 2021
| @@ -1,5 +1,5 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="de" id="erz-absenzenmanagement-dev"> | |||
| <html id="erz-absenzenmanagement-dev"> | |||
There was a problem hiding this comment.
Diese Changes sind wohl ausversehen reingerutscht :)
There was a problem hiding this comment.
Mit dem lang="de" kann man die Sprache lokal gar nie umstellen. Deshalb habe ich das entfernt.
caebr
reviewed
Aug 4, 2021
|
|
||
| switch (lang) { | ||
| case 'fr-CH': | ||
| return value.replace(':', ' :'); |
There was a problem hiding this comment.
Sollte das nicht generisch sein? So dass man vor irgendeinem Zeichen einen Space einfügen kann? Ansonsten müsste die Pipe spezifischer heissen.
There was a problem hiding this comment.
Ja das habe ich mir auch überlegt. Dann käme noch ? und ! hinzu. Allerdings hat es keine solche Vorkommen und ich wollte keinen Code auf Vorrat bauen. Was meinst du?
|
@caebr kannst du nochmal drüber schauen und ggf. mergen. habs dynamischer gemacht. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Einfache pipe, welche Zeit nur ein Space for
:fürfr-CHhinzufügt. Andere vorkommen von Sonderzeichen habe ich im Code nicht gefunden (?,!).