Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/233 absences other teachers review #297

Merged
merged 4 commits into from
Jun 9, 2021
Merged

Feature/233 absences other teachers review #297

merged 4 commits into from
Jun 9, 2021

Conversation

caebr
Copy link
Collaborator

@caebr caebr commented Jun 4, 2021 •
edited
Loading

Beim Testing dieser Story sind noch ein paar Sachen aufgetaucht. Könntest du nochmals kurz drüber schauen?

@caebr caebr self-assigned this Jun 4, 2021
@caebr caebr requested a review from spahrson June 4, 2021 11:18
spahrson
spahrson approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@spahrson spahrson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Für mich sieht das gemäss den Kommentaren aus dem Issue gut aus.

src/app/presence-control/utils/lessons.ts
lessonPresence: LessonPresence,
lesson: Option<LessonEntry>
): ReadonlyArray<LessonAbsence> {
return uniqBy(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schön gelöst.

@caebr caebr merged commit e0a7842 into master Jun 9, 2021
@mfehlmann mfehlmann deleted the feature/233-absences-other-teachers-review branch April 21, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spahrson spahrson spahrson approved these changes

Assignees

@caebr caebr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caebr @spahrson