Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/230 x role restriction #278

Merged
merged 9 commits into from
Apr 22, 2021
Merged

Conversation

caebr
Copy link
Collaborator

@caebr caebr commented Apr 21, 2021

No description provided.

@caebr caebr requested a review from hupf April 21, 2021 12:16
@caebr caebr self-assigned this Apr 21, 2021
Copy link
Collaborator

@hupf hupf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht super aus, auch sehr gut getestet 👌

}

private getCurrentModuleName(): string | null {
const urlSegment = this.router.url
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das ist nur der Angular Teil oder? Dann finde ich dies eine gute Variante 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, genau. Alles nach dem #
Die ActivatedRoute enhält scheinbar nur in Komponenten die Infos zur Route.

});

it('should add header on open absences module', () => {
// fail
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was meinst du hier damit?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, da hatte ich was vergessen zu löschen :)

@caebr caebr force-pushed the feature/230-x-role-restriction branch from 1506784 to a191e91 Compare April 22, 2021 07:39
@caebr caebr force-pushed the feature/230-x-role-restriction branch from a191e91 to a5e5027 Compare April 22, 2021 09:28
@caebr caebr merged commit 82b04a1 into master Apr 22, 2021
@mfehlmann mfehlmann deleted the feature/230-x-role-restriction branch April 21, 2022 11:42
@mfehlmann mfehlmann restored the feature/230-x-role-restriction branch April 21, 2022 11:42
@mfehlmann mfehlmann deleted the feature/230-x-role-restriction branch April 21, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants