Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/133 search by module instance #162

Merged
merged 6 commits into from
Apr 28, 2020
Merged

Feature/133 search by module instance #162

merged 6 commits into from
Apr 28, 2020

Conversation

caebr
Copy link
Collaborator

@caebr caebr commented Apr 22, 2020

No description provided.

@caebr caebr requested a review from hupf April 22, 2020 13:40
hupf
hupf reviewed Apr 22, 2020
View reviewed changes
Copy link
Collaborator

@hupf hupf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hupf
hupf requested changes Apr 22, 2020
View reviewed changes
Copy link
Collaborator

@hupf hupf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemäss Ticket, müsste im Dropdown noch die Number in Klammern angezeigt werden... die Frage ist wie wichtig das ist. Das würde wohl wieder eine rechte Anpassung der Typeahead Komponente bedeuten.

@caebr
Copy link
Collaborator Author

caebr commented Apr 22, 2020

Gemäss Ticket, müsste im Dropdown noch die Number in Klammern angezeigt werden... die Frage ist wie wichtig das ist. Das würde wohl wieder eine rechte Anpassung der Typeahead Komponente bedeuten.

Du hast recht. Die Number ist ja aber schon Teil der Designation. Wie oben umgesetzt wäre das dann z.B. "2-1-Biologie-MNW-2019/20-22a (2-1-B-MNW-GYM20-22a)".

@caebr caebr assigned hupf and unassigned caebr Apr 27, 2020
@caebr caebr requested a review from hupf April 27, 2020 13:41
hupf
hupf requested changes Apr 27, 2020
View reviewed changes
Copy link
Collaborator

@hupf hupf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noch die beiden Änderungen, der Rest ist gut.

src/app/shared/services/educational-events-rest.service.ts Outdated Show resolved Hide resolved
src/app/shared/services/educational-events-rest.service.ts Outdated Show resolved Hide resolved
@hupf hupf assigned caebr and unassigned hupf Apr 27, 2020
@caebr caebr force-pushed the feature/133-search-by-module-instance branch from 8b2c634 to 183c03c Compare April 27, 2020 15:05
@caebr caebr requested a review from hupf April 27, 2020 15:05
@caebr caebr force-pushed the feature/133-search-by-module-instance branch from 183c03c to e47e437 Compare April 27, 2020 15:13
@caebr caebr force-pushed the feature/133-search-by-module-instance branch from e47e437 to 64f24a3 Compare April 28, 2020 07:19
@caebr caebr merged commit 3bb061e into master Apr 28, 2020
@caebr caebr deleted the feature/133-search-by-module-instance branch April 29, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hupf hupf hupf approved these changes

Assignees

@caebr caebr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caebr @hupf