Texture format info: Invert R and B in RGBA4 #2878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is incorrect:
This is correct on mine: |
|
Ah never-mind I see it was disabled... |
|
Half right. It should actually be this. My changes weren't properly pushed 😨 |
|
This format: MTLPixelFormatBGR5A1Unorm, not MTLPixelFormatA1BGR5Unorm |
mipek
pushed a commit
to mipek/bgfx
that referenced
this pull request
Mar 2, 2024
* texture format info: Invert R and B in RGBA4 d3d9: Revert 06c08ad to force software conversion because the format doesn't exist d3d11: Force software conversion because the format doesn't exist gl: Revert 3e3e655 to swizzle R and B mtl: Swizzle channels * metal: Remove explicit conversion of RGBA4 and RGB5A1 in osx * metal: Set alpha bit to correct end of short
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d3d9: Revert 06c08ad to force software
conversion because the format doesn't exist
d3d11: Force software conversion because the format doesn't exist
gl: Revert 3e3e655 to swizzle R and B
mtl: Swizzle channels
Removed software conversion in metal for RGBA4 and RGB5A1.
Fix alpha in RGB5A1
Tested in metal:
