Update for Thunderbird 54 #1
Conversation
It seems nsPreferences has been removed in Thunderbird 54. Use a wrapper to emulate it. Fix the paths in the manifest Signed-off-by: Ian Wienand <ian@wienand.org>
|
In principle, I'm not opposed to this change. Clearly an update is appropriate. My concern is the licensing on the code you imported. Since the page is in Japanese, I can't read it, but not knowing its origin, I can't know its license. Can you either get permission to import it, or reimplement it based on the C++ at https://hg.mozilla.org/integration/mozilla-inbound/rev/2dca0ba58df6abd5c5f5b260644b3b56f6e7e69b#l14.2? |
|
Yeah, on further investigation I found that too ... I just pulled it in from before the removal and it seems to work; see 64b3e1f |
|
That should be fine. If you push that change into this pull request, I'll merge it. I'll need to update the LICENSE file and the README to note that that code is under the MPL v2.0. |
|
Gentle ping, @ianw. I'm happy to take the updated patch should you push it into this pull request. |
2 participants
It seems nsPreferences has been removed in Thunderbird 54. Use a
wrapper to emulate it.
Fix the paths in the manifest
Signed-off-by: Ian Wienand ian@wienand.org