Skip to content

Drop redundant installation of bundler and migrate bundle exec to other workflows #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2023
Merged

Drop redundant installation of bundler and migrate bundle exec to other workflows #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bc031e
Don't install bundler, which comes with Ruby 2.7+
billybooth Sep 16, 2023
1202b91
Install dependencies and use bundler to exec fastlane across workflows
billybooth Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/add_identifiers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,18 @@ jobs:
# Checks-out the repo
- name: Checkout Repo
uses: actions/checkout@v3

# Patch Fastlane Match to not print tables
- name: Patch Match Tables
run: find /usr/local/lib/ruby/gems -name table_printer.rb | xargs sed -i "" "/puts(Terminal::Table.new(params))/d"


# Install project dependencies
- name: Install Project Dependencies
run: bundle install

# Create or update identifiers for app
- name: Fastlane Provision
run: fastlane identifiers
run: bundle exec fastlane identifiers
env:
TEAMID: ${{ secrets.TEAMID }}
GH_PAT: ${{ secrets.GH_PAT }}
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/build_loop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,12 +251,10 @@ jobs:
- name: Patch Match Tables
run: find /usr/local/lib/ruby/gems -name table_printer.rb | xargs sed -i "" "/puts(Terminal::Table.new(params))/d"

# Install Bundler and project dependencies
- name: Install Bundler and project dependencies
run: |
gem install bundler
bundle install

# Install project dependencies
- name: Install project dependencies
run: bundle install

# Build signed Loop IPA file
- name: Fastlane Build & Archive
run: bundle exec fastlane build_loop
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/create_certs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,18 @@ jobs:
# Checks-out the repo
- name: Checkout Repo
uses: actions/checkout@v3

# Patch Fastlane Match to not print tables
- name: Patch Match Tables
run: find /usr/local/lib/ruby/gems -name table_printer.rb | xargs sed -i "" "/puts(Terminal::Table.new(params))/d"


# Install project dependencies
- name: Install Project Dependencies
run: bundle install

# Create or update certificates for app
- name: Create Certificates
run: fastlane certs
run: bundle exec fastlane certs
env:
TEAMID: ${{ secrets.TEAMID }}
GH_PAT: ${{ secrets.GH_PAT }}
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/validate_secrets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,10 @@ jobs:
steps:
- name: Checkout Repo
uses: actions/checkout@v3


- name: Install Project Dependencies
run: bundle install

- name: Validate Fastlane Secrets
run: |
# Validate Fastlane Secrets
Expand Down Expand Up @@ -171,7 +174,7 @@ jobs:
elif ! echo "$FASTLANE_KEY" | openssl pkcs8 -nocrypt >/dev/null; then
failed=true
echo "::error::The FASTLANE_KEY secret is set but invalid. Verify that you copied it correctly from the API Key file (*.p8) you downloaded and try again."
elif ! fastlane validate_secrets 2>&1 | tee fastlane.log; then
elif ! bundle exec fastlane validate_secrets 2>&1 | tee fastlane.log; then
if grep -q "bad decrypt" fastlane.log; then
failed=true
echo "::error::Unable to decrypt the Match-Secrets repository using the MATCH_PASSWORD secret. Verify that it is set correctly and try again."
Expand Down