Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MiniRacer for TruffleRuby #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement MiniRacer for TruffleRuby #1

wants to merge 1 commit into from

Conversation

bjfish
Copy link
Owner

@bjfish bjfish commented Jan 25, 2022

No description provided.

@bjfish bjfish force-pushed the truffleruby branch 10 times, most recently from b5fe716 to 0ac0125 Compare January 28, 2022 19:39
bjfish
bjfish commented Jan 28, 2022
View reviewed changes
lib/mini_racer/truffleruby.rb Outdated Show resolved Hide resolved
bjfish
bjfish commented Jan 28, 2022
View reviewed changes
lib/mini_racer/truffleruby.rb Outdated Show resolved Hide resolved
bjfish
bjfish commented Jan 28, 2022
View reviewed changes
lib/mini_racer/truffleruby.rb Outdated Show resolved Hide resolved
@bjfish bjfish force-pushed the truffleruby branch 2 times, most recently from 2d965c9 to 8770ab7 Compare January 28, 2022 20:06
eregon
eregon reviewed Feb 1, 2022
View reviewed changes
test/mini_racer_test.rb Outdated Show resolved Hide resolved
eregon
eregon reviewed Feb 1, 2022
View reviewed changes
test/mini_racer_test.rb Outdated Show resolved Hide resolved
@bjfish
Copy link
Owner Author

bjfish commented Feb 1, 2022

@eregon Ready for re-review.

eregon
eregon reviewed Feb 7, 2022
View reviewed changes
lib/mini_racer.rb Outdated Show resolved Hide resolved
eregon
eregon reviewed Feb 10, 2022
View reviewed changes
lib/mini_racer.rb Outdated Show resolved Hide resolved
eregon
eregon reviewed Feb 10, 2022
View reviewed changes
lib/mini_racer.rb Outdated Show resolved Hide resolved
eregon
eregon reviewed Feb 10, 2022
View reviewed changes
test/mini_racer_test.rb Outdated Show resolved Hide resolved
@bjfish bjfish force-pushed the truffleruby branch 2 times, most recently from 7148cde to 42db483 Compare February 15, 2022 18:28
@bjfish bjfish force-pushed the truffleruby branch 3 times, most recently from e9ba64c to d9db2ce Compare April 15, 2022 17:43
@bjfish bjfish force-pushed the truffleruby branch 2 times, most recently from 74ee332 to b193325 Compare April 26, 2022 20:29
@bjfish
Copy link
Owner Author

bjfish commented May 18, 2022

@eregon I've updated this to the on_cancelled callback and it is ready for review. One thing still missing is updated character positions in the backtrace due to the inner context not accepting the use strict option yet.

eregon
eregon approved these changes Jul 8, 2022
View reviewed changes
lib/mini_racer/truffleruby.rb Outdated Show resolved Hide resolved
lib/mini_racer/truffleruby.rb Outdated Show resolved Hide resolved
lib/mini_racer/truffleruby.rb Outdated Show resolved Hide resolved
lib/mini_racer/truffleruby.rb Outdated Show resolved Hide resolved
lib/mini_racer/truffleruby.rb Outdated Show resolved Hide resolved
lib/mini_racer/truffleruby.rb Outdated Show resolved Hide resolved
lib/mini_racer/truffleruby.rb Outdated Show resolved Hide resolved
test/function_test.rb Outdated Show resolved Hide resolved
test/mini_racer_test.rb Outdated Show resolved Hide resolved
test/test_forking.rb Outdated Show resolved Hide resolved
@bjfish bjfish force-pushed the truffleruby branch 4 times, most recently from 0d33b88 to 8fb619d Compare July 12, 2022 21:49
@bjfish bjfish mentioned this pull request Jul 12, 2022
Merged
eregon
eregon reviewed Jul 13, 2022
View reviewed changes
lib/mini_racer/truffleruby.rb Outdated Show resolved Hide resolved
lib/mini_racer/truffleruby.rb Outdated Show resolved Hide resolved
lib/mini_racer/truffleruby.rb Show resolved Hide resolved
lib/mini_racer/truffleruby.rb Outdated Show resolved Hide resolved
@bjfish bjfish force-pushed the truffleruby branch 2 times, most recently from 33ab13d to 6206a1e Compare July 19, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjfish @eregon