fix(proof): bound filtered mailbox preflights - #483
Merged
bizzybee90 merged 1 commit intoAug 10, 2026
Merged
Conversation
bizzybee90
deployed
to
release-status-ledger-writer
August 10, 2026 23:10 — with
GitHub Actions
Active
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe product-proof system now supports a filtered mailbox current-inbound contract for ChangesFiltered mailbox inbound contract
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant FilteredMailboxRoute
participant RequestCollector
participant LiveEvidenceRecorder
FilteredMailboxRoute->>RequestCollector: Send needs-action or unread inbound request
RequestCollector->>LiveEvidenceRecorder: Provide validated canonical request
LiveEvidenceRecorder->>LiveEvidenceRecorder: Track bounded preflight and completion
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Repair the fail-closed product-proof policy mismatch exposed by governed staging proof run
31439834363: tenant-Aneeds-actiondesktop emitted a second exactmailbox-current-inbound-optionspreflight while its already-required base request contract is exactly two occurrences.Included scope
needs-actionandunreadmailbox-current inbound request identity.Explicit exclusions
sentand every unrelated route remain one-shot unless covered by an existing separately reviewed exact contract.Architecture placement
Current owner / directory: existing product-proof network compiler and live evidence recorder under
scripts/.Dependencies and duplicate-system check: extends the existing frozen-contract, exact matcher, browser-managed preflight and completion-debt mechanisms; no new subsystem or dependency.
Security and tenancy impact
Data impact
Verification
1 !== 2; repaired network+live focused suites324/324; broader cloud+network+live514/514; full Vitest871/871; exact debt, completed/in-flight cap, alternate-workspace, route-wide one-shot and redaction cases.git diff --checkpass; local security review reports zero findings. Fresh hosted exact-head gates and CodeRabbit approval are mandatory.Release safety
67a3afb4; predecessor exact main4f7534ad533f46e3d9593fa02b4e2144a10bdfad, preview manifestc2700cefa1e572911e2709b1cea39f3ac123840421a3ff41577d7ccfd9275a73.Documentation and generated files
Completion check
origin/main.Policy exceptions (leave blank when none apply)
PR-size exception rationale:
Retained branch reason / owner / review date / maximum retention date:
Exact evidence
31439834363on exact4f7534ad533f46e3d9593fa02b4e2144a10bdfadfailed only at tenant-Aneeds-actiondesktop with fixed diagnosticlive_browser_managed_preflight_invalid / cdp / request / mailbox-current-inbound-options / policy_occurrence_exhausted.1; this change raises only the exact reviewed pair to max2and keeps the existing completion-debt relation.Summary by CodeRabbit
New Features
Bug Fixes