fix(proof): bound workload preflight repeats - #466
Merged
bizzybee90 merged 1 commit intoAug 10, 2026
Merged
Conversation
bizzybee90
temporarily deployed
to
release-status-ledger-writer
August 10, 2026 11:58 — with
GitHub Actions
Inactive
📝 WalkthroughWalkthroughThe PR adds a Home live-workload cutoff contract for the ChangesHome live workload cutoff
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Home
participant createSourceRequestCollector
participant liveEvidenceRecorder
participant Supabase
Home->>Supabase: request email_provider_configs with contract query
Supabase-->>createSourceRequestCollector: return GET and OPTIONS network events
createSourceRequestCollector->>liveEvidenceRecorder: provide context, route, viewport, and lifecycle data
liveEvidenceRecorder-->>Home: validate completion and occurrence bounds
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
coderabbitai
Bot
temporarily deployed
to
release-status-ledger-writer
August 10, 2026 11:59
Inactive
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/product-proof-network-policy.test.mjs`:
- Around line 974-978: Update the routeOptions list so the
live-workload-cutoff-options entry is included for both the home and channels
routes, matching the desktop OPTIONS requests emitted by
addDesktopSidebarRequests while preserving the existing exclusion for other
routes.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 01af7d94-7115-4188-bb2c-38ae177ad12c
📒 Files selected for processing (4)
scripts/product-proof-live-evidence.mjsscripts/product-proof-live-evidence.test.mjsscripts/product-proof-network-policy.mjsscripts/product-proof-network-policy.test.mjs
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Repair the exact fail-closed blocker from governed proof run 31383676961: a second valid
live-workload-cutoff-optionslifecycle exhausted a one-shot OPTIONS policy while the canonical Home desktop cutoff GET is source-owned with exactly four occurrences.Included scope
email_provider_configsGET with orderedselect, workspace filter, ordered cutoff fields, andlimit=1, plus exact fetch/null/min 4/max 4 and public profile/app-origin identity.live-workload-cutoff-optionsto use min 0/max 4.Exact evidence
Run 31383676961 on exact source
be98bedf1a491d7c4cdf8af3b31fcb51a13dd15estopped at tenant-a / home / desktop-1440x900 withlive-workload-cutoff-options → policy_occurrence_exhausted. Exact source/deployment binding passed. Cleanup, aggregate postflight, and recovery passed; writer/reader were skipped and the run published zero evidence artifacts.Explicit exclusions
No generic descriptor registry, matcher sharing, or occurrence propagation; no alternate route, viewport, tenant, workspace, URL/query/header/method/resource/body/bounds/label; no fifth occurrence; no unrelated policy, timeout, count, global-limit, application, workflow, dependency, schema, credential, provider, billing, customer, staging, or production change.
Architecture placement
Current owner / directory: existing product-proof network-policy compiler and live-evidence recorder under
scripts/; no new subsystem.Dependencies and duplicate-system check: a frozen primitive descriptor removes literal drift, while compiler and recorder independently reconstruct the dynamic workspace UUID, ordered URL/query, origins, headers, labels, method, body, resource, route, viewport, context, and bounds. Existing CORS generation and repeatable-preflight completion-debt lifecycle are reused.
Security and tenancy impact
Data impact
Verification
Release safety
be98bedf1a491d7c4cdf8af3b31fcb51a13dd15e/ manifest6d85d7915e37d11efa3944df09765c998bf722daeeaadf7c3114b59b7f3d5779; no production action.Documentation and generated files
Completion check
origin/main.Policy exceptions (leave blank when none apply)
PR-size exception rationale: four files and one coherent safety fix; 887 inserted lines are dominated by isolated lifecycle, identity, debt, count, diagnostic, source-ownership, TOCTOU, and privacy tests required to prove the exact exception cannot widen.
Retained branch reason / owner / review date / maximum retention date:
Summary by CodeRabbit
New Features
Bug Fixes
Tests