This repository was archived by the owner on Mar 15, 2024. It is now read-only.
[Refactor] Use rxjs first instead of unsubscribe from queryParams #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
As discussed in bitwarden/jslib#470, we currently call
unsubscribe()on the queryParams object from within its callback. This is a bit of an anti-pattern and can throw an error about the subscription variable being undefined.Code changes
Use the rxjs
firstoperator instead. This will automatically unsubscribe from the observable after the first value is emitted. We should use this pattern from now on.This does not strictly depend on bitwarden/jslib#516, but we should include the jslib update in this PR so that it's all together.