[PM-21925] Add MasterPasswordSalt Column to User Table#6950
Draft
ike-kottlowski wants to merge 7 commits intomainfrom
Draft
[PM-21925] Add MasterPasswordSalt Column to User Table#6950ike-kottlowski wants to merge 7 commits intomainfrom
ike-kottlowski wants to merge 7 commits intomainfrom
Conversation
…entation and associated stored procedures. feat: supply transitional sql script to hydrate password salt column. feat: supply finalization script for altering column to be not null, and associated stored procedures. chore: sync SQL project with added scripts
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6950 +/- ##
==========================================
+ Coverage 56.25% 60.22% +3.96%
==========================================
Files 1976 1976
Lines 87525 87526 +1
Branches 7809 7809
==========================================
+ Hits 49238 52710 +3472
+ Misses 36459 32899 -3560
- Partials 1828 1917 +89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… possible out of date server.
…ub.com/bitwarden/server into auth/pm-21925/add-password-salt-column
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-21925
📔 Objective
To support the separation of salt from the email we need to track the salt in the user table. This is an additive change.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes