[PM-31153] email updates for domain claim pt 2#6942
Conversation
* Updated the email template to include the claimed domain name and user email. * Modified the `ClaimedUserDomainClaimedEmails` model to include the domain name. * Adjusted the `SendClaimedDomainUserEmailAsync` method to pass the domain name to the email message. * Added a new test for rendering the domain claimed email to ensure proper content delivery.
* Adjusted styles and formatting in the DomainClaimedByOrganization email template for improved readability. * Modified the TitleContactUs layout to ensure proper rendering of titles. * Updated the HandlebarsMailService to include HTML line breaks in the email title for better presentation.
…mproved presentation
|
New Issues (2)Checkmarx found the following issues in this Pull Request
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
…gn property for improved consistency in styling
...ore/AdminConsole/OrganizationFeatures/OrganizationDomains/VerifyOrganizationDomainCommand.cs
Show resolved
Hide resolved
|
Claude finished @JaredScar's task in 2m 1s —— View job Code Review SummaryPR: PM-31153 email updates for domain claim pt 2 OverviewThis PR enhances domain claimed email notifications by adding the claimed domain name and user email to the email template, improving context for end users. The template styling has also been refined. Review Status: ApprovedAll previous feedback has been addressed:
Files Reviewed
Outstanding ItemOne existing suggestion remains open regarding the unused Automated review by Claude |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| TitleFirst = $"Important update to your<br>Bitwarden account", | ||
| OrganizationName = CoreHelpers.SanitizeForEmail(org.DisplayName(), false), | ||
| DomainName = domainName, | ||
| EmailDomain = emailAddress.Split('@').LastOrDefault() ?? "", |
There was a problem hiding this comment.
SUGGESTED: The EmailDomain property is computed here but never referenced in the email template (DomainClaimedByOrganization.html.hbs uses DomainName and UserEmail, but not EmailDomain).
Consider removing this unused property assignment, or if it's intended for future use, add a comment explaining the intent.
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
|
2 participants
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-31153
📔 Objective
Fix up email template after feedback from product. Keep in mind this updates the ContactUs template, so it will affect all emails that use this template as well.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes