-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-28300] Remove BlockClaimedDomainAccountCreation feature flag checks #6934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6934 +/- ##
==========================================
- Coverage 60.21% 56.27% -3.95%
==========================================
Files 1976 1976
Lines 87536 87522 -14
Branches 7810 7807 -3
==========================================
- Hits 52714 49249 -3465
- Misses 32907 36443 +3536
+ Partials 1915 1830 -85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Patrick-Pimentel-Bitwarden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Auth changes look good!
|





🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-28300
📔 Objective
Remove feature flag checks for
BlockClaimedDomainAccountCreation.Clients PR.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes