[PM-17562] Add GET endpoints for event integrations #6104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6104 +/- ##
==========================================
- Coverage 51.86% 51.83% -0.04%
==========================================
Files 1730 1732 +2
Lines 76422 76519 +97
Branches 6817 6820 +3
==========================================
+ Hits 39639 39663 +24
- Misses 35231 35304 +73
Partials 1552 1552 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
withinfocus
requested changes
Jul 18, 2025
...o/Stored Procedures/OrganizationIntegrationConfiguration_ReadByOrganizationIntegrationId.sql
Outdated
Show resolved
Hide resolved
src/Sql/dbo/Stored Procedures/OrganizationIntegration_ReadByOrganizationId.sql
Outdated
Show resolved
Hide resolved
...ator/DbScripts/2025-07-18_00_AddReadManyOrganizationIntegrationAndConfigurationByIdProcs.sql
Outdated
Show resolved
Hide resolved
…ant/add-get-api-endpoints-for-event-integrations
Base automatically changed from
brant/add-support-for-all-events-configuration
to
main
July 22, 2025 14:02
|
withinfocus
approved these changes
Jul 23, 2025
|
@BTreston this is ready for AC team review. |
BTreston
approved these changes
Jul 23, 2025
brant-livefront
deleted the
brant/add-get-api-endpoints-for-event-integrations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-17562
📔 Objective
This PR adds database and API support for GET endpoints on the API. Specifically:
organizations/{organizationId}/integrationsorganizations/{organizationId}/integrations/{integrationId}/configurationsI've also altered the OrganizationIntegrationResponseModel to include the configuration. And I've also added an optional
string? Serviceproperty toHecIntegration. This allows the front end to store a service enum into the object when it is created. When a user comes back to the page and the FE polls to see what is configured, it can use the Service parameter to determine which HEC service the user had setup previously.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes