-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-15614] Allow Users to opt out of new device verification #5176
Open
ike-kottlowski
wants to merge
7
commits into
main
Choose a base branch
from
auth/pm-15614/allow-new-device-opt-out
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9,459
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vices column in [dbo].[User].
…r has opted out of device verification. Added endpoint to AccountsController.cs to allow editing of new User.VerifyDevices property.
…t. Removed Anon attribute from the POST account/verify-devices endpoint.
…fyDevices. Added update to verify email to the new device verification flow.
New Issues
Fixed Issues
|
…onSignUpCommand that were failing.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5176 +/- ##
=======================================
Coverage ? 43.34%
=======================================
Files ? 1459
Lines ? 66510
Branches ? 6082
=======================================
Hits ? 28831
Misses ? 36387
Partials ? 1292 ☔ View full report in Codecov by Sentry. |
JimmyVo16
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-15614
📔 Objective
Some users would like to be able to turn off the new device verification feature. This PR is to enable that decision.
However, turning this off will reduce overall security of your account if you do not already have 2FA enabled.
📸 Screenshots
User is able to login when
dbo.User.VerifyDevices
is set to false (0)PRRh7o4c8a.mp4
Transcript
User tries to login and is met with New Device Verification prompt.
dbo.User.VerifyDevices
is changed to false (0); user attempts to login again and are allowed to authenticate this time.dbo.User.VerifyDevices
is set back to true (1); User tries to authenticate again and is successful again because the device has been saved as a knowndevice.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes