Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-11162] Assign to Collection Permission Update #4844
base: main
Are you sure you want to change the base?
[PM-11162] Assign to Collection Permission Update #4844
Changes from 21 commits
c147b5b
c705b40
f541285
0df254a
441d2e7
a9d1df6
2b55485
786b054
5c672ec
5f7fb0c
f841ec5
f7135fb
710b0e2
7f15dc3
2215d45
23d8790
c5d772e
a86a45a
e498acb
5eb650f
92cd2ba
2e92275
2cd32b6
7de47e4
ced2997
a240df3
c40ce6d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ญ We should ask QA to test a few scenarios where a cipher has both group and user assignments with mixed
ReadOnly
andHidePasswords
permissions to be sure the users is still allowed to perform the action with the most permissive relationship.I think this query will still work as expected for those scenarios, but its probably something we should confirm with some additional testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge can be problematic with excessive locking, better just update or delete:
`CREATE OR ALTER PROCEDURE [dbo].[CollectionCipher_UpdateCollections]
@cipherid UNIQUEIDENTIFIER,
@userid UNIQUEIDENTIFIER,
@CollectionIds AS [dbo].[GuidIdArray] READONLY
AS
BEGIN
SET NOCOUNT ON
END
GO`